Jobs output expandable section #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithjgrant
requested changes
May 6, 2024
There was a problem hiding this comment.
This is great! Just a couple things I would suggest improving:
If you collapse all, then expand the Play, the "collapse all" button is still in the collapsed state and clicking it once doesn't expand/collapse anything. I think you might need to setCollapsedAll(false) any time a single item is expanded or collapsed.
MilanPospisil
force-pushed
the
milan_controller_jobs_output_expandable_section
branch
from
1fcad09
to
f4a0146
Compare
keithjgrant
approved these changes
May 10, 2024
fullsushidev
pushed a commit
that referenced
this pull request
Jun 17, 2024
ShaiahWren
pushed a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-14459
https://issues.redhat.com/browse/AAP-14717
Find job with type Playbook run. Then detail and outputs.
What is added:
Topmost expand all expands Playbooks and Tasks outputs.
When section is expanded, it renders (...) rectangle under line number.